Skip to content

Port unified archiver binary from monad-bft - #8

Open
mhumeSF wants to merge 4 commits into
mh/local-deb-packagingfrom
mh/unify-archive-binary
Open

mhumeSF wants to merge 4 commits into
mh/local-deb-packagingfrom
mh/unify-archive-binary

Conversation

@mhumeSF

@mhumeSF mhumeSF commented Aug 31, 2026

Copy link
Copy Markdown

Ports the unified archiver from category-labs/monad-bft#3195: one monad-archive binary with subcommands instead of four binaries that each bundled the same dependencies. The services pick up their settings from /etc/monad-services/env, and the checker no longer holds whole block chunks in memory.

A few things from the bft PR got fixed in the port:

  • logging was set up twice (globally and again by the checker), which would crash the checker at startup
  • the checker's default log filter still pointed at the old binary name, so it matched nothing
  • help text and examples still showed the old binary names
  • cargo would have picked up src/bin/cli.rs as a stray extra binary
  • the moved tests didn't compile (stale import paths)

Stacked on #7, which merges first.

Ports category-labs/monad-bft#3195: the four binaries pulled in the same
dependencies, so the split only bloated the package. The systemd units
also gain the arguments they were missing.
The checker and rechecker collected all 1000 blocks of a chunk from every
replica before processing any of them. Peak memory is now bounded by
--concurrency rather than the chunk size.
The default directive still targeted monad_archive_checker, which no longer
matches any module path, so the checker logged nothing unless RUST_LOG was set.
Clap env bindings replace the ${VAR} flag expansion in the units, so a
variable left unset falls back to its built-in default instead of leaving
a dangling flag. Flags still take precedence when given; the shipped
/etc/default/monad-services documents the variables.
@mhumeSF
mhumeSF force-pushed the mh/local-deb-packaging branch from c29fce6 to 23cb933 Compare August 31, 2026 20:25
@mhumeSF
mhumeSF force-pushed the mh/unify-archive-binary branch from 6700041 to 31b8666 Compare August 31, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant