zkvm: execute block - #2554
Open
goodlyrottenapple wants to merge 9 commits into
Open
zkvm: execute block#2554goodlyrottenapple wants to merge 9 commits into
goodlyrottenapple wants to merge 9 commits into
Conversation
goodlyrottenapple
force-pushed
the
sam/zkvm-execute-block
branch
from
September 11, 2026 12:32
30cdea9 to
d60c041
Compare
goodlyrottenapple
changed the base branch from
main
to
sam/rlp-decode-block
September 11, 2026 12:35
goodlyrottenapple
marked this pull request as ready for review
September 11, 2026 12:36
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| // Ordered-trie root for the block-body binding. Self-contained on purpose: | ||
| // the node computes these roots through its database machinery, which the |
Contributor
There was a problem hiding this comment.
[P2] Hand-rolled MPT/RLP consensus code has no unit test
ordered_trie_root reimplements hex-prefix encoding, the embedded-node (<32-byte) rule, and RLP integer keys from scratch, and its correctness argument in this comment is only the end-to-end mainnet comparison — which the x86 runner exercises manually, not under ctest. A subtle bug (e.g. in the 128+-item key encoding, or the embedded-child threshold, which only bites with small receipts) would surface as an unexplained root mismatch far from this code. A small host-side gtest checking known vectors — empty trie → NULL_ROOT, a single item, and a >128-item trie against a canonical mainnet transactions root — would pin this down cheaply; per REVIEW.md § Testing, new source should carry a matching *_test.cpp.
goodlyrottenapple
force-pushed
the
sam/zkvm-execute-block
branch
from
September 11, 2026 13:13
d60c041 to
6056ba9
Compare
goodlyrottenapple
force-pushed
the
sam/rlp-decode-block
branch
from
September 11, 2026 13:13
6312712 to
1a3921e
Compare
goodlyrottenapple
force-pushed
the
sam/zkvm-execute-block
branch
3 times, most recently
from
September 14, 2026 14:57
b9e2e61 to
f59d52b
Compare
goodlyrottenapple
force-pushed
the
sam/rlp-decode-block
branch
from
September 14, 2026 14:57
1a3921e to
709f3bb
Compare
goodlyrottenapple
force-pushed
the
sam/zkvm-execute-block
branch
from
September 14, 2026 14:58
f59d52b to
aa9cb43
Compare
goodlyrottenapple
force-pushed
the
sam/rlp-decode-block
branch
from
September 14, 2026 14:58
709f3bb to
f2cd515
Compare
goodlyrottenapple
force-pushed
the
sam/zkvm-execute-block
branch
from
September 14, 2026 15:10
aa9cb43 to
4c5722e
Compare
goodlyrottenapple
force-pushed
the
sam/rlp-decode-block
branch
2 times, most recently
from
September 14, 2026 15:37
8052b2f to
d12b6c0
Compare
goodlyrottenapple
force-pushed
the
sam/zkvm-execute-block
branch
4 times, most recently
from
September 15, 2026 09:55
9740495 to
40b069f
Compare
The decoder currently loops while the payload is no less than 32 bytes, meaning it will silently drop any "trailing" bytes instead of throwing a decoding error Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ansactions buffer for views to undecoded transactions Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The guest CMakeLists builds two ways: a bare-metal RISC-V static archive (cross-compile mode, driven by build-support) that adapts the host monad_execution/monad_precompiles OBJECT libs via source/library drops, and a host x86 test-runner executable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…rawals root, receipts root
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 8176ab9)
goodlyrottenapple
force-pushed
the
sam/rlp-decode-block
branch
from
September 15, 2026 11:00
d12b6c0 to
4efc3c7
Compare
goodlyrottenapple
force-pushed
the
sam/zkvm-execute-block
branch
from
September 15, 2026 11:00
40b069f to
2fc347f
Compare
Baltoli
force-pushed
the
sam/rlp-decode-block
branch
from
September 18, 2026 14:46
4efc3c7 to
d0dbe7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.