fix(validator): ignore retired feed_down_fallback on status - #159
Merged
wallscaler merged 1 commit intoAug 28, 2026
Merged
Conversation
Status is journal-only and does not use the retired [provenance].feed_down_fallback option. A leftover TOML key still rejects serve, preflight-launch, and reconcile-launch so a stale config cannot imply a fallback exists. A missing feed still fails closed. Co-authored-by: Ancient Runner <wallscaler@users.noreply.github.com>
wallscaler
marked this pull request as ready for review
August 28, 2026 22:58
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e8a9103f-3347-4315-aa98-72b1a218f863) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny follow-up to #157 (squash-merged as
af234b3), not a reopen. Codex P2 on #157: leftover[provenance].feed_down_fallbackin operator TOML madecathedral-validator statusraise an uncaughtValueErrorbefore the journal was read, even though status is journal-only and does not use that runtime option.#157 (comment)
What changed
statusloads a TOML that still contains[provenance].feed_down_fallback(any value) and reaches the journal / interval settings viahealth.evaluate.serve,preflight-launch, andreconcile-launchstill reject the retired key (ValueError) so a leftover TOML cannot silently imply a fallback exists._CONFIG_MAPdoes not grow a mapping forfeed_down_fallback. The key is ignored on status; rejected on write/startup paths.Holds
--confirm-uid30-launch,--broadcast, wallet load,serve_axon).CATHEDRAL_ALLOCATION_CONTRACT=v3.api.cathedral.computeris still Cloudflare 522; a dead feed must keep failing closed.Please review; do not self-merge.