test(cmd): reset cobra flags between runs so -count is usable - #124
Merged
Conversation
These tests drive the shared global rootCmd, and cobra flag values are sticky: once "version --short" has run, --short stays set on that command, so a later plain "version" printed only the number. Within one run the subtests happened to be ordered such that this never showed; under -count=2 four tests fail. That made -count unusable for this package — and a test that only passes in one particular order is a test that can hide a real regression just as easily. Flags are now reset to their defaults before each execution. Pre-existing: v2.5.1 fails the same way.
The flag-reset helper imports pflag directly (cobra's FlagSet.VisitAll takes a *pflag.Flag), so go.mod and the SBOM record it as direct rather than indirect. No new module enters the graph — cobra already pulled it in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests drive the shared global rootCmd, and cobra flag values are sticky:
once "version --short" has run, --short stays set on that command, so a later
plain "version" printed only the number. Within one run the subtests happened to
be ordered such that this never showed; under -count=2 four tests fail.
That made -count unusable for this package — and a test that only passes in one
particular order is a test that can hide a real regression just as easily. Flags
are now reset to their defaults before each execution. Pre-existing: v2.5.1
fails the same way.