Skip to content

Update translation#133

Merged
cbrnr merged 4 commits into
cbrnr:masterfrom
darktemplarbasealt:update_translation
Sep 24, 2021
Merged

Update translation#133
cbrnr merged 4 commits into
cbrnr:masterfrom
darktemplarbasealt:update_translation

Conversation

@darktemplarbasealt

Copy link
Copy Markdown
Contributor

No description provided.

@cbrnr

cbrnr commented Sep 14, 2021

Copy link
Copy Markdown
Owner

Thanks, in many cases it seems like you could directly use tr() instead of QObject::tr() – I think this makes the code more readable.

@darktemplarbasealt

Copy link
Copy Markdown
Contributor Author

It's my preference to use QObject::tr(), but it's easy for me to replace it with tr(). I'll update this change.

@cbrnr

cbrnr commented Sep 15, 2021

Copy link
Copy Markdown
Owner

Thanks @darktemplarbasealt! Please give me some time to test this, I am currently busy with so many other things and I haven't even set up a build env for SigViewer (same for #132).

@darktemplarbasealt

Copy link
Copy Markdown
Contributor Author

Sure. I'm testing it too, and found an issue. I'll update this change soon.

@darktemplarbasealt

Copy link
Copy Markdown
Contributor Author

Now it works for me.

@cbrnr

cbrnr commented Sep 24, 2021

Copy link
Copy Markdown
Owner

It seems like the include for tr() is missing at least in this file:

src/file_handling_impl/biosig_basic_header.cpp:144:25: error: use of undeclared identifier 'tr'
        addPatientInfo (tr("Birthday"), QString (ctime(&birthday_t)).trimmed());

@darktemplarbasealt

Copy link
Copy Markdown
Contributor Author

Sorry, replaced QObject::tr with tr without double-checking. Should be fixed now.

@cbrnr cbrnr merged commit e86b58d into cbrnr:master Sep 24, 2021
@cbrnr

cbrnr commented Sep 24, 2021

Copy link
Copy Markdown
Owner

Thanks @darktemplarbasealt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants