Compose: mount config/ read-only into the worker so configuration changes are a restart - #75
Open
oldeucryptoboi wants to merge 1 commit into
Open
oldeucryptoboi wants to merge 1 commit into
oldeucryptoboi wants to merge 1 commit into
Conversation
…nges are a restart Only config/temporal.yaml was mounted into the worker; models.yaml, connectors.yaml and parsers.yaml came from the image, so every model or connector change needed dev.sh worker --build, several minutes per iteration. The API compose already mounts the whole directory. The worker now mounts ../../config:/app/config:ro like the API. The baked copy stays as the fallback for a hand-run container. dev.sh, the README and the quick start no longer tell users to rebuild for configuration changes. Closes cbtw-apac#71 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
Why
docker-compose.temporal.ymlmounted onlyconfig/temporal.yaml;models.yaml,connectors.yamlandparsers.yamlcame from the worker image. Every model or connector change meantdev.sh worker --build, several minutes per iteration. The API compose already mounts the whole directory.What
../../config:/app/config:ro, matching the API. The baked copy remains the fallback for a hand-run container without the mount.dev.shusage text,README.mdanddocs/getting-started/quick-start.mdsay--buildis for source or dependency changes and that configuration changes need onlydev.sh worker/dev.sh api.Checks
docker compose -f docker-compose.temporal.yml config --quietpasses with the standard env files. Verified locally: amodels.yamlchange picked up bydev.sh workerwithout a rebuild.🤖 Generated with Claude Code