Conversation
A cleaned up, minimal push of the spherical harmonic calculator designed for ChucK's math library.
This change implements a ulib_math entry which allows for the function to actually be called by users. Includes documentation of the function.
|
This build has been tested and confirmed to be working on an Intel Mac, Ubuntu machine and Windows as of 02/21 |
Previously, memory was allocated by SH() which would return a pointer for the ulib function to access. This meant one function allocated memory and the other deleted it. Now ulib will allocate memory and provide a pointer to SH() for it to use, meaning SH() is not responsible for management of memory.
gewang
left a comment
There was a problem hiding this comment.
thank you! we will go ahead and merge;
as follow-ups, we would ask for one or more tests examples (with expected output); also, could you provide a link or brief explanation for the "magic constants" used in ck_associated_legendre()
|
hello @gewang , wonderful! thank you for allowing me to be a part of ChucK. I will open a PR with some examples and display .sh()'s functionality with some calculation examples as well as ambisonic encoding via Gain[]. as for
|
I have included a clean push of all changes for Math.sh(), only changing core files.
@gewang