Skip to content

Minor Bug Fix in Example & Readme - #1

Open
min-guk wants to merge 1 commit into
cds-ruc:mainfrom
min-guk:main
Open

min-guk wants to merge 1 commit into
cds-ruc:mainfrom
min-guk:main

Conversation

@min-guk

@min-guk min-guk commented Jan 12, 2024

Copy link
Copy Markdown

Dear Repository Owner,

Congratulations on having your paper accepted at SIGMOD 2024.
I enjoyed reading it as it was both highly interesting and engaging.

While attempting to conduct my own experiments, I noticed what seems to be a minor issue in the example source code.

[ 50%] Building CXX object CMakeFiles/example_mt.dir/src/examples/example_multithread.cpp.o
SALI/src/examples/example_multithread.cpp: In function ‘int main()’:
SALI/src/examples/example_multithread.cpp:25:47: error: no matching function for call to ‘sali::SALI<int, int>::at(int&)’
   25 |     std::cout<<"value at "<<i<<": "<<sali.at(i)<<std::endl;

Though I'm not entirely certain, based on my understanding, it appears that it could be corrected as follows.

// example_multithread.cpp
#pragma omp parallel for schedule(static, 12)
  for (int i = 0; i < 2000; i++) {
    int val = 0;
    sali.at(i, val);
    std::cout<<"value at "<<i<<": "<<val<<std::endl;
  }

This modification seems to ensure that the build process works smoothly and that the results are accurate.
Could you please check on this?

Best regards,
Minguk Choi

@Yzwhash

Yzwhash commented Mar 1, 2024

Copy link
Copy Markdown

中国人我就不多说了,好兄弟,能给一份你们测试的代码吗,自己写的测试代码有很大问题,与论文中实验结果不匹配

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants