Skip to content

Fix a high priority bug with the masking system which was introduced in the switch to reconstructors classes#52

Merged
yoshikisd merged 1 commit intomasterfrom
bugfix/masking
Oct 24, 2025
Merged

Fix a high priority bug with the masking system which was introduced in the switch to reconstructors classes#52
yoshikisd merged 1 commit intomasterfrom
bugfix/masking

Conversation

@allevitan
Copy link
Collaborator

There was a typo in the reconstructors class which broke the masking system. I noticed it today while working on a separate project.

I believe this change fixes it, and in addition I:

  • Checked the entire file for all uses of "self" in recconstructors/base.py and the subclasses to check if any similar bugs had slipped by the earlier round of review
  • Added a few lines to test_fancy_ptycho which will cause that reconstruction to fail with an unacceptably large error if the masking system stops working. I prefer folding it into the same test, rather than making a separate test, to keep the number of slow tests down.

@allevitan allevitan requested a review from yoshikisd October 24, 2025 13:15
@allevitan allevitan added the bug Something isn't working label Oct 24, 2025
Copy link
Collaborator

@yoshikisd yoshikisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this Abe! This all looks good to me. I also tested the pytest on my machine.

@yoshikisd yoshikisd merged commit 1fa9a75 into master Oct 24, 2025
6 checks passed
@yoshikisd yoshikisd deleted the bugfix/masking branch October 24, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants