Change to Pyproject.toml installation and uv, remove python 3.8 support, add python 3.13 and 3.14 support#57
Merged
allevitan merged 8 commits intocdtools-developers:masterfrom Nov 12, 2025
Conversation
Collaborator
Author
|
@allevitan it looks like we are losing python 3.8 with the latest |
Collaborator
|
@gnzng What do you prefer to do? Drop support for python 3.8 or test with an earlier version of pytorch? |
Collaborator
Author
|
@allevitan I would probably recommend discontinuing support for Python 3.8, as it reached end of life and no longer receives security updates. |
Collaborator
|
Agreed |
allevitan
requested changes
Nov 12, 2025
Collaborator
allevitan
left a comment
There was a problem hiding this comment.
I tested installation from source with the new pyproject.toml on my system and went through the files. I just have a few small comments to address before we merge.
This was referenced Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits from this PR were recently discussed in #56:
be28903:
requirements.txtand removes outdatedsetup.py728cf9d: