Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the per-command completion blocks in install.sh into a single data-driven loop that iterates over a list of commands and dispatches to a generate_completion() function. Also switches the script from /bin/sh to Bash with set -euo pipefail.
Changes:
- Replaced five repetitive
if command -v ...blocks with acmdsarray and a shared loop. - Added a
generate_completion()function with acasestatement mapping each command to its zsh-completion invocation. - Switched shebang to
#!/usr/bin/env bashand enabledset -euo pipefail; added an explicitmkdir -pfor the site-functions directory.
Show a summary per file
| File | Description |
|---|---|
| install.sh | Consolidates completion generation into an array + loop + case dispatch and hardens shell options. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.