Skip to content

Comments

updated documentation of delete#144

Open
penguincarol wants to merge 1 commit intomasterfrom
riemenschneider/delete
Open

updated documentation of delete#144
penguincarol wants to merge 1 commit intomasterfrom
riemenschneider/delete

Conversation

@penguincarol
Copy link
Contributor

As requested, I updated the docu to reflect the behaviour of the returning-statement in delete. We may want to adapt the example to something more meaningful once cascading deletes are no longer hidden behind a feature flag.

returning *;
```

The returning clause refers to the state of the database after the delete is completed. Any deleted tuples are no longer visibles to scans, that may occur in the returning clause.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first sentence is a bit misleading because the deleted tuples are returned, how about just

Suggested change
The returning clause refers to the state of the database after the delete is completed. Any deleted tuples are no longer visibles to scans, that may occur in the returning clause.
Scans in the returning clause read the database after the delete is completed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That phrasing is significantly better!

- adhered to PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants