Skip to content

Conversation

@Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 15, 2026

See https://tombi-toml.github.io/tombi/docs/json-schema for full details on the schema format

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for cedarjs ready!

Name Link
🔨 Latest commit 4ef552b
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/696a53faa66e6e00089b6da3
😎 Deploy Preview https://deploy-preview-1006--cedarjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 15, 2026

Greptile Summary

This PR adds JSON Schema validation support for Cedar/Redwood configuration files (cedar.toml and redwood.toml) through two new files:

  1. cedar.schema.json: A comprehensive JSON Schema Draft 7 definition covering all configuration sections (web, api, browser, generate, graphql, notifications, studio, experimental, and eslintLegacyConfigWarning). The schema is well-structured and includes proper type definitions and descriptions.

  2. tombi.toml: A Tombi configuration file that maps both cedar.toml and redwood.toml files to the cedar.schema.json schema, enabling IDE schema validation and autocomplete in editors like VS Code.

Critical Issue Identified: The schema marks path as required in both the web (line 36) and api (line 60) sections, but this is a legacy unused property that doesn't appear in any actual project configurations. All test configs work without this property, making the schema validation overly restrictive and creating false validation errors.

The integration with Tombi enables seamless schema validation in development environments, providing developers with real-time feedback on configuration validity.

Confidence Score: 2/5

  • Schema has a critical validation issue that will cause legitimate configurations to fail validation
  • The schema marks path as required for both web and api sections, but investigation shows this is a legacy property that's never used and doesn't appear in any test configurations. This creates false validation failures. Once this required field issue is fixed, the PR would be safe to merge. The tombi.toml file itself is correctly configured.
  • cedar.schema.json - specifically the required arrays on lines 36 and 60 where path should be removed

Important Files Changed

Filename Overview
cedar.schema.json JSON Schema Draft 7 for cedar.toml/redwood.toml configuration. Comprehensive coverage of all config sections. Issue: path property is marked required in both web and api sections but is a legacy unused field not found in any test configurations. This creates false validation errors.
tombi.toml Tombi configuration file for VS Code schema association. Correctly maps both cedar.toml and redwood.toml to the cedar.schema.json file. No issues detected.

Sequence Diagram

sequenceDiagram
    participant User
    participant VSCode as VS Code IDE
    participant Tombi as tombi.toml
    participant Schema as cedar.schema.json
    participant TOML as redwood.toml
    
    User->>VSCode: Opens redwood.toml file
    VSCode->>Tombi: Reads Tombi associations
    Tombi->>Schema: Locates cedar.schema.json
    Schema->>TOML: Applies validation rules
    TOML->>VSCode: Schema validation feedback
    VSCode->>User: Shows validation errors/autocomplete
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@github-actions github-actions bot added this to the next-release milestone Jan 15, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 15, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 4ef552b

Command Status Duration Result
nx run-many -t test --minWorkers=1 --maxWorkers=4 ✅ Succeeded 3s View ↗
nx run-many -t test:types ✅ Succeeded 10s View ↗
nx run-many -t build ✅ Succeeded 6s View ↗
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-16 15:23:17 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants