fork xwiki-core-velocity to celements-xwiki-velocity#281
Open
fork xwiki-core-velocity to celements-xwiki-velocity#281
Conversation
msladek
approved these changes
Feb 15, 2026
Member
There was a problem hiding this comment.
why is this a move? was XWikiResourceManagerImpl deleted from celements-xwiki-core?
Comment on lines
+267
to
+268
| <!-- XWiki rendering modules, listed here so that they are included in the | ||
| distribution |
Member
There was a problem hiding this comment.
your formatter is wrapping lines too early. is max width set to low in your IDE?
Comment on lines
+433
to
+434
| <!-- The JRCS JARS are are in our repo till we get them published on the | ||
| central repository. |
Member
There was a problem hiding this comment.
your formatter is wrapping lines too early. is max width set to low in your IDE?
Comment on lines
+511
to
+516
| <!-- JTidy hasn't been released for ages (since 2001). A snapshot version | ||
| exists at | ||
| http://jtidy.sourceforge.net/snapshots/ but Maven requires non-snapshots in | ||
| order to | ||
| allow a release (this is for reproducibility). Thus we've had to upload JTidy | ||
| into |
Member
There was a problem hiding this comment.
your formatter is wrapping lines too early. is max width set to low in your IDE?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.