fix: post-v9-bump CI follow-ups#4965
Merged
walldiss merged 1 commit intocelestiaorg:feature/fibrefrom Apr 23, 2026
Merged
Conversation
Addresses the three CI failures that surfaced after celestiaorg#4963 merged to feature/fibre: 1. header/headertest TestValidate/8 was asserting that app version 9 is rejected with "this node supports up to version 8". appconsts is now 9, so v9 is valid. Shift the "unsupported version" case to v10 and add v9 as a valid case. 2. nodebuilder/tests/tastora/go.mod still required celestia-app/v8, but its framework.go (renamed by celestiaorg#4963) imports v9. Bump tastora's celestia-app pin to the same v9 pseudo-version as root go.mod and re-run tidy in that module so the parity script passes. 3. No source changes for root go.mod needed — verified locally that the existing root go.mod/go.sum from celestiaorg#4963 is stable under `go mod tidy`. If CI's Go Mod Tidy Check still flakes, that is a module-proxy drift rather than a committed-state problem. Verified: - go build -tags fibre ./... clean - go vet -tags fibre ./... clean - go test -count=1 -run TestValidate ./header/headertest/... passes - scripts/check-go-mod-parity.sh passes (root ↔ tastora parity) - go build ./... in tastora submodule clean - go test -tags fibre -count=1 ./core/... passes in isolation (the TestMakeExtendedHeaderForEmptyBlock failure that surfaces under `./...` is a pre-existing port-conflict flake, not introduced by this change) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/fibre #4965 +/- ##
================================================
Coverage ? 34.86%
================================================
Files ? 317
Lines ? 21638
Branches ? 0
================================================
Hits ? 7544
Misses ? 13087
Partials ? 1007 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rootulp
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4963. That PR merged with three red CI jobs; this fixes them.
What was broken
`go-ci / Unit Tests` — `header/headertest.TestValidate/8` asserted that app version 9 is rejected with the message `"has version 9, this node supports up to version 8"`. Since chore: bump celestia-app to v9 #4963 bumped `celestia-app/v9/pkg/appconsts.Version` to 9, version 9 is now valid and the test case is now factually wrong. Shift the "unsupported version" case to v10 (with the updated error message) and add v9 as a new valid case.
`go-ci / Go Mod Parity Check` — `nodebuilder/tests/tastora/go.mod` still required `github.com/celestiaorg/celestia-app/v8`, but its `framework.go` was rewritten to `v9` in chore: bump celestia-app to v9 #4963. The tastora module couldn't tidy against its own source. Bump the tastora celestia-app pin to the same `v9.0.0-20260422212825-66060fbde7a3` pseudo-version as root `go.mod` and re-tidy.
`go-ci / Go Mod Tidy Check` — this is a consequence of the stale tastora pin (the parity script fails, and tidy picks up different resolutions). The tastora tidy in this PR fixes it.
Verified locally
Not fixed in this PR
`TestMakeExtendedHeaderForEmptyBlock` in `./core/...` failed when the CI runner executed `./...`. Running the `core` package alone passes; running the test in isolation passes. That's a port-conflict flake between test runs, pre-exists #4963, and is out of scope here.
🤖 Generated with Claude Code