keep PC matrix 2-dimensional even if only one PC#4
Open
wes-brooks wants to merge 1 commit intocemordaunt:masterfrom
Open
keep PC matrix 2-dimensional even if only one PC#4wes-brooks wants to merge 1 commit intocemordaunt:masterfrom
wes-brooks wants to merge 1 commit intocemordaunt:masterfrom
Conversation
The prior code will fail when only one PC is selected because by default R will drop the singleton dimension and then the result is not an array type, so `dimnames(PCs)` generates an error. adding `drop = FALSE` to the subset keeps the singe PC as a column matrix, so everything will work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior code will fail when only one PC is selected because by default R will drop the singleton dimension and then the result is not an array type, so
dimnames(PCs)generates an error. Addingdrop = FALSEto the subset keeps the single PC as a column matrix, so everything will work.