Skip to content

update to latest breaking changes in k8s-sig-storage-cosi sidecar#43

Merged
thotz merged 5 commits intoceph:masterfrom
gattytto:update
Sep 26, 2025
Merged

update to latest breaking changes in k8s-sig-storage-cosi sidecar#43
thotz merged 5 commits intoceph:masterfrom
gattytto:update

Conversation

@gattytto
Copy link
Copy Markdown

@gattytto gattytto commented Sep 18, 2025

Closes: #42

Recent changes in module structure from upstream sidecar code in k8s-sig-storage-cosi enforce restrictive permissions and breaks .sock consumption.

There's also a chance to match grpc version and bump some imports versions.

when this is pushed upstream rook/ceph can bump container version of bth this app and the sidecar to newer versions.

SIDE NOTE: should be revisited when v1alpha2 rolls out, specially for changes in cosi secret structure

@gattytto
Copy link
Copy Markdown
Author

@thotz 👋

go.mod Outdated
@@ -1,32 +1,31 @@
module github.com/ceph/cosi-driver-ceph
module github.com/ceph/cosi-driver
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why name is changed ?

Copy link
Copy Markdown
Collaborator

@thotz thotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the module name as ceph-cosi-driver. Otherwise change looks good. Can also print output of make build and make container as well in comment

@gattytto
Copy link
Copy Markdown
Author

gattytto commented Sep 24, 2025

I have reverted the naming changes as you requested here are the logs

~/ceph-cosi-clean % make build
mkdir -p bin
CGO_ENABLED=0 GOOS=linux go build -a -ldflags '-X main.version=36082e395587b9cd343d503e40c04cdb3c89de3b -extldflags "-static"' -o ./bin/ceph-cosi-driver ./cmd/ceph-cosi-driver
if [ "$ARCH" = "amd64" ]; then \
        CGO_ENABLED=0 GOOS=windows go build -a -ldflags '-X main.version=36082e395587b9cd343d503e40c04cdb3c89de3b -extldflags "-static"' -o ./bin/ceph-cosi-driver.exe ./cmd/ceph-cosi-driver ; \
        CGO_ENABLED=0 GOOS=linux GOARCH=ppc64le go build -a -ldflags '-X main.version=36082e395587b9cd343d503e40c04cdb3c89de3b -extldflags "-static"' -o ./bin/ceph-cosi-driver-ppc64le ./cmd/ceph-cosi-driver ; \
fi

I have mistakenly pushed changes to Makefile and Dockerfile which I have already reverted in the latest commit of the PR

for the moment I can't run the make container command because of my setup

@thotz thotz merged commit c59d2d3 into ceph:master Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cephCosiDriver needs security context set to 65532 with new kube-sigs sidecar

2 participants