update to latest breaking changes in k8s-sig-storage-cosi sidecar#43
Merged
thotz merged 5 commits intoceph:masterfrom Sep 26, 2025
Merged
update to latest breaking changes in k8s-sig-storage-cosi sidecar#43thotz merged 5 commits intoceph:masterfrom
thotz merged 5 commits intoceph:masterfrom
Conversation
Author
|
@thotz 👋 |
thotz
reviewed
Sep 19, 2025
go.mod
Outdated
| @@ -1,32 +1,31 @@ | |||
| module github.com/ceph/cosi-driver-ceph | |||
| module github.com/ceph/cosi-driver | |||
thotz
reviewed
Sep 19, 2025
Collaborator
thotz
left a comment
There was a problem hiding this comment.
Please keep the module name as ceph-cosi-driver. Otherwise change looks good. Can also print output of make build and make container as well in comment
Author
|
I have reverted the naming changes as you requested here are the logs ~/ceph-cosi-clean % make build
mkdir -p bin
CGO_ENABLED=0 GOOS=linux go build -a -ldflags '-X main.version=36082e395587b9cd343d503e40c04cdb3c89de3b -extldflags "-static"' -o ./bin/ceph-cosi-driver ./cmd/ceph-cosi-driver
if [ "$ARCH" = "amd64" ]; then \
CGO_ENABLED=0 GOOS=windows go build -a -ldflags '-X main.version=36082e395587b9cd343d503e40c04cdb3c89de3b -extldflags "-static"' -o ./bin/ceph-cosi-driver.exe ./cmd/ceph-cosi-driver ; \
CGO_ENABLED=0 GOOS=linux GOARCH=ppc64le go build -a -ldflags '-X main.version=36082e395587b9cd343d503e40c04cdb3c89de3b -extldflags "-static"' -o ./bin/ceph-cosi-driver-ppc64le ./cmd/ceph-cosi-driver ; \
fi
I have mistakenly pushed changes to Makefile and Dockerfile which I have already reverted in the latest commit of the PR for the moment I can't run the make container command because of my setup |
thotz
approved these changes
Sep 26, 2025
This was referenced Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #42
Recent changes in module structure from upstream sidecar code in k8s-sig-storage-cosi enforce restrictive permissions and breaks .sock consumption.
There's also a chance to match grpc version and bump some imports versions.
when this is pushed upstream rook/ceph can bump container version of bth this app and the sidecar to newer versions.
SIDE NOTE: should be revisited when v1alpha2 rolls out, specially for changes in cosi secret structure