Open
Conversation
…busy exhausted loop when user code calls `continue` and an error when user code calls `break` when an empty field data chunk is encountered.
joelposti
force-pushed
the
field-boundary-finding-causes-busy-exhausted-loop
branch
from
c730002 to
7c57dcf
Compare
Author
|
I first wrote these tests as integration tests. But I converted them to unit tests since it looks like the repo has zero integration tests. If you want these as integration tests instead, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests that prove that the current field boundary finding logic causes a busy exhausted loop when user code calls
continueand an error when user code callsbreakwhen an empty field data chunk is encountered.More detailed explanation in issue Field boundary finding logic causes a busy exhausted loop.