feat: replace defunct Valve-protocol principal with GameServersService - #85
Merged
cetteup merged 1 commit intoJul 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates Valve server listing away from the defunct Valve-protocol principal query to Steam’s IGameServersService/GetServerList Web API by introducing a dedicated provider and wiring it into the Valve lister/CLI.
Changes:
- Add
ValveGameServersServiceProviderto query Steam Web API and returnClassicServerentries. - Refactor
ValveServerListerto delegate listing to aValveProvider. - Update Valve principal config to
api.steampowered.com:443and add CLI support for providing a Steam Web API key.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| GameserverLister/providers/valve.py | Introduces Web API-backed Valve provider and request/response parsing. |
| GameserverLister/listers/valve.py | Switches Valve listing to provider-based retrieval instead of pyvpsq.PrincipalServer. |
| GameserverLister/games/valve.py | Updates Valve “principal” endpoint to Steam Web API host/port. |
| GameserverLister/commands/valve.py | Adds --web-api-key CLI option and constructs the new provider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cetteup
force-pushed
the
feat/replace-valve-protocol-with-game-servers-service
branch
from
July 5, 2026 13:49
c54966d to
63fac35
Compare
cetteup
marked this pull request as ready for review
July 5, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.