Skip to content

Finished implementation of game basis#128

Open
Mudy63345 wants to merge 3 commits into
cfrantzidis:masterfrom
Mudy63345:master
Open

Finished implementation of game basis#128
Mudy63345 wants to merge 3 commits into
cfrantzidis:masterfrom
Mudy63345:master

Conversation

@Mudy63345

Copy link
Copy Markdown

No description provided.

@KubaSlv KubaSlv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for Mohamed Asas
By Jakub Sliwinski 28986939

Code compiles and runs to some expectation
Well structured and implemented error handling of erroneous inputs, such as empty inv
Great use of switch cases

Evidence of:
Classes & objects
Evident throughout the program, Player class, Room class, or player and currentRoom objects

Encapsulation
Also evident in certain parts of the code, such as, private fields, player currentRoom

Exception handling
Some error handling evident, such as bypassing erroneous inputs with logic,

Overall, there is some room for improvement,
some recommended additions, could be,
encapsulate more, certain parts contained public fields,
could make use more use of exception handling, such as exception catching,
could include lists of items and descriptions to make use of

@Archiitecttt

Archiitecttt commented Mar 14, 2025

Copy link
Copy Markdown

Review for Mohamed Asas

by Will Anderson 29291126

Requirements

Your code meets all the requirements

Readability and style guidelines

The code's readability is good - well formatted with clear and concise naming of objects, methods, variables, etc.
Style guidelines have been followed properly.

Error handling

There's also good handling of multiple different kinds of errors throughout the code.

Improvements

Using a multiple line string with Console.WriteLine(@"Your string") would be better than multiple uses of the Writeline() method one after another to print multiple lines.
Other than that, after the updates made since the previous review, there isn't much I can see to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants