Skip to content

Dungeon Crawler Peer Review#131

Open
Winterspear wants to merge 2 commits into
cfrantzidis:masterfrom
Apoc187:Development
Open

Dungeon Crawler Peer Review#131
Winterspear wants to merge 2 commits into
cfrantzidis:masterfrom
Apoc187:Development

Conversation

@Winterspear

Copy link
Copy Markdown

Peer Review

1.0 and such

@Winterspear Winterspear left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to stick to a consistent formatting, camelCase should be used for all parameters, while PascalCase should be used for Namespace Type, Interface, Methods, Properties, Events and Fields.

The code is well deigned and is very in-depth. The UI is a very useful addition as it allows for the user to have an intuitive method to traverse the game.

I see that you have started to implement an enemy system, as well as a combat system. It would be nice to see that completed in future implementations.

Comments could be useful throughout the code, I see you have added a couple, but multi-line comments could be useful for understanding the purpose of each function.

The inventory management system is very in-depth. Well done.

updated to remove profanity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants