Update Program.cs#18
Open
codegonegirth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
The original code was simple and basic but did work it was hard to read however. The variable names were just random letters which made it hard to follow the code also had no comments making it hard to understand. Additionally, when entering the wrong file name or if the file wasn’t there it would just crash with no reasoning which left me confused at times. The function that counted the words was working however basic, however, the output was wall of text not very user friendly.
After:
I’ve gone through and cleaned up all the variables so now have proper names so it’s way easier to figure out what’s happening I also added a check to make sure the file exists before trying to read it to stop the program from crashing. In Addition, I moved some of the logic out of Main() into separate functions to make it easier to follow and more user friendly. The output is now nicely sorted and more readable. Overall, it’s just more polished and is easier to follow for users especially if a collaborator needs to look at it or work on it later.