Skip to content

Code review and improvements#19

Open
munaxshe wants to merge 1 commit into
cfrantzidis:masterfrom
munaxshe:master
Open

Code review and improvements#19
munaxshe wants to merge 1 commit into
cfrantzidis:masterfrom
munaxshe:master

Conversation

@munaxshe

Copy link
Copy Markdown

Hi,

As part of my OOP resit assignment, I’ve taken some time to review this code and suggest improvements that could make it clearer and easier to maintain. Here’s a quick summary of what I’ve done in this pull request:

  • Changed a few variable names to make them more descriptive (for example, I changed ‘z’ to ‘filePath’).
  • Added some comments to explain what certain functions and parts of the code do.
  • Put in some basic error handling for file reading, so the program doesn’t crash if the file is missing.
  • Tweaked some of the output messages to make them more user-friendly.

I’ve tried to leave detailed comments in the code to explain each suggestion and why I think it helps. Hope this is useful!

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant