Update Program.cs#16
Open
codegonegirth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version of this program is a lot easier to use and to understand. The code starts by asking for a full file path and checks if the file exists this helps prevent crashing this is a great improvement as the code no longer confuses the user with its little reasoning for why the crashing happens. The code is also more organised and uses clear and easy to understand variable names (filePath, wordCounts, and cleanedLine) so it’s easier for a collaborator to follow. It is also skipping null words and sorts the results alphabetically, which makes the output look a lot cleaner which is a substantial improvement.
There’s still room to make it better however for example it could show the top few most common words or include comments explaining how aspects of the code work such as the use of regular expressions. This would increase the user friendliness drastically but overall it’s a big step up and much more user/collabration friendly.