Create Code review (resit)#7
Open
Sam-H06 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming
There's a couple variables in this that have non-descriptive names and make the code more difficult to understand, for example:
program-->WordFrequencyAppS-->cleanedLineHowever overall, this code uses recognisable names such as:
filePathlineswordCountsCode Structure
code is easier to follow when responsibilities are clearly divided.
main(), LoadFile(), cleanText(), countWords(), and DisplayResults() helps understand the flow. On the other hand, the code lacks reusability
Error Handling + File assumptions
only checks if file exists - could check empty files, files that are unreadable, or files that are extremely large.
prevents crashes as it uses Try-Catch blocks which catch unexpected errors and prevent app shutdown.
OOP Principles
-> No encapsulation, all logic is exposed in a single method.
-> No abstraction
-> No polymorphism, all behaviour is hardcoded, no flexibility to swap or extend parts.
Output
code is hard to export results, automate processing, or use in other programs.
gives the user little to no info about the file that was analysed
Program Logic
code is inefficient for large files, as it uses
file.ReadAllLines()loads the entire file into memory - negative for larger files