Skip to content

Code review #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snowy988 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code review #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
573fdab
Create Code_Review.txt
snowy988 Jul 30, 2025
ef10d26
Update Code_Review.txt
snowy988 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Code_Review.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
1) Naming
- variable names are clear

2) Code structure
- entire coding inside main - split up into separate methods

3) Error handling
- program checks to see if files exist

- Doesnt't handle file is empty

4) File assumptions
- program assumes the file is small and plain text - add validate file content

5) OOP Principles
- procedural
- all within main
- introducee clases

6) Output
- Output is clear and simple
- make output more user friendly

7) Program logic
- Works
- doesn't handle contraction words
- use smarter regex