refactor: simplify reload chat#156
Open
notshekhar wants to merge 3 commits intocgoinglove:mainfrom
Open
Conversation
Updated the handleModelChange function to remove the model parameter and streamline the reload logic. The SelectModel component has been commented out, and the button now directly triggers the handleModelChange function.
|
@notshekhar is attempting to deploy a commit to the cgoinglove's projects Team on Vercel. A member of the Team first needs to authorize it. |
notshekhar
changed the title
Collaborator
|
There are a few Ts erors, thanks for your PR |
Owner
|
While I appreciate the simplification, I actually prefer the previous UX because it allowed me to select the model directly, and I didn't find it particularly cumbersome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the handleModelChange function to remove the model parameter and streamline the reload logic. The SelectModel component has been commented out, and the button now directly triggers the handleModelChange function. This change addresses an issue where the model selector would reload the chat with the already selected model, regardless of the user's choice, so the selector was removed for simplicity.