feat(ps5): firmware passthrough, mic LED callback, and feature report stubs#5
Open
hkirste wants to merge 2 commits into
Open
feat(ps5): firmware passthrough, mic LED callback, and feature report stubs#5hkirste wants to merge 2 commits into
hkirste wants to merge 2 commits into
Conversation
- Add WDK install step to CI workflow (windows-latest no longer includes it) - Upload full build output directory to capture driver files alongside the user-mode library
…port stubs - Accept optional FirmwareInfo blob in WINUHID_PS5_GAMEPAD_INFO. When provided, serve it for GET_FEATURE 0x20 instead of the built-in default. This enables hosts to pass through the real controller's firmware version. - Add PWINUHID_PS5_MIC_LED_CB callback, invoked when the host sets MicMuteLedValid in the output report (values: 0=off, 1=on, 2=pulse). - Return zero-filled data for unimplemented feature reports instead of NULL, preventing WebHID clients from freezing during device enumeration. - Update default firmware info to a modern version to prevent spurious firmware update prompts when no passthrough data is available.
lurebat
pushed a commit
to lurebat/WinUHid
that referenced
this pull request
Apr 29, 2026
- Add MicLedCallback parameter to WinUHidPS5Create FFI binding - Add FirmwareInfo/FirmwareInfoLength fields to WINUHID_PS5_GAMEPAD_INFO - Add MicLed device event variant and callback implementation - Document mic_led WebSocket message type in web/README.md - Update README.md to reference just install-driver and BUILDING.md - Note vcpkg is now a Git submodule (PR cgutman#2) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lurebat
pushed a commit
to lurebat/WinUHid
that referenced
this pull request
Apr 29, 2026
Add NULL MicLedCallback argument to all WinUHidPS5Create calls to match the new 7-parameter signature from PR cgutman#5. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FirmwareInfoblob inWINUHID_PS5_GAMEPAD_INFO. When provided, serve it verbatim forGET_FEATURE 0x20instead of the built-in default. Enables hosts to pass through the real controller's firmware version from the client.PWINUHID_PS5_MIC_LED_CBcallback, invoked when the host setsMicMuteLedValidin the output report (values: 0=off, 1=on, 2=pulse).Also fixes the CI workflow to install WDK on
windows-latest(no longer pre-installed) and uploads full build output including driver files.Test plan
Jul 4 2025firmware appears on virtual device)WINUHID_PS5_GAMEPAD_INFOget default behavior (backwards compatible)