Merged
Conversation
4 tasks
lxcong
added a commit
that referenced
this pull request
Apr 23, 2026
## Summary Release-please PR #6 (bumping to v1.1.0) revealed that the `version` file wasn't being auto-updated — `plugin.json`, `CHANGELOG.md`, and `.release-please-manifest.json` all bumped correctly, but `version` stayed at `1.0.0`. Root cause: the `generic` extra-files updater requires `# x-release-please-version` anchor markers in the file. Our `version` file is a bare version string with no markers, so release-please silently skipped it. Consequence if left unfixed: `check-update.sh` reads `version` to compare with remote releases — users would see "UPDATED: v1.1.0" on every skill invocation after v1.1.0 publishes, because the local `version` file never advances. ## Fix - Rename `version` → `version.txt`. The `simple` release-type in release-please auto-manages `version.txt` by convention, no extra-files entry needed. - Drop the obsolete `{"type": "generic", "path": "version"}` entry from `release-please-config.json`. - Update `check-update.sh` VERSION_FILE pointer. - Set `version.txt` to `1.1.0` so it matches what PR #6 will cut. ## Merge order This PR first, **then** release PR #6. Release-please will see `version.txt=1.1.0` already in place and leave it alone; `plugin.json` will still bump from 1.0.0 → 1.1.0 as usual. ## Test plan - [x] `python3 -c "import json; json.load(open('release-please-config.json'))"` OK - [x] `bash -n skills/agentkey/scripts/check-update.sh` OK - [x] `git mv` preserves history - [ ] Post-merge + post-release-PR: `git show v1.1.0:version.txt` equals `1.1.0` Co-authored-by: lxcong <lxhtheresa@gmail.com>
lxcong
deleted the
release-please--branches--main--components--agentkey-skill
branch
Contributor
Author
|
🤖 Created releases: 🌻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
1.1.0 (2026-04-23)
Features
This PR was generated with Release Please. See documentation.