Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.1.0 release-please tag came out as
agentkey-skill-v1.1.0instead ofv1.1.0, becauserelease-pleasedefaultsinclude-component-in-tag: truefor simple release-type. That created inconsistency with v1.0.0's barev1.0.0tag (which was hand-tagged during migration cutover).I've already renamed the v1.1.0 tag + release to match v1.0.0's convention. This PR ensures future releases stay consistent by adding
include-component-in-tag: false.Test plan
python3 -c "import json; json.load(open('release-please-config.json'))"OKv1.1.0andv1.0.0tags are both bare-vformat (verified viagh api repos/.../tags)vX.Y.Zformat, notagentkey-skill-vX.Y.Z