Omit empty sbom-format from Verify invocation - #1028
Open
puerco wants to merge 1 commit into
Open
Conversation
The template-injection hardening in chainguard-dev#901 moved the optional sbom-format input into a quoted env var. This turns into an empty string when the input is not set and the java invocation fails: Invalid file type: Process completed with exit code 1. But the action needs to omit the format positional argument to rely on the SPDX tools' format detection. This PR modifies the invocation to pass the value with ${INPUTS_SBOM_FORMAT:+...} so the argument is only passed when the input is non-empty. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template-injection hardening in #901 moved the optional sbom-format input into a quoted env var. This turns into an empty string when the input is not set and now the java invocation of thes SPDX fail on all workflows that don't define a value:
(see for example this run on the kubernetes org)
The action needs to support omitting the format positional argument to rely on the SPDX tools' format detection.
This PR modifies the invocation to pass the value with
${INPUTS_SBOM_FORMAT:+...}so the argument is only passed when the input is non-empty.