Skip to content

Add support for gzip-compressed CPIO output #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lavishpal wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

Add support for gzip-compressed CPIO output #2253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions internal/cli/build-cpio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,13 @@
package cli

import (
"compress/gzip"
"context"
"fmt"
"io"
"os"
"runtime"
"strings"

"github.com/spf13/cobra"

Expand Down Expand Up @@ -109,8 +112,15 @@ func BuildCPIOCmd(ctx context.Context, dest string, opts ...build.Option) error
}
defer f.Close()

// TODO(mattmoor): Consider wrapping in a gzip writer if the filename
// ends in .gz
// Use a gzip-compressed writer when the output filename ends with .gz.
var w io.Writer = f

return cpio.FromLayer(layer, f)
if strings.HasSuffix(dest, ".gz") {
gzw := gzip.NewWriter(f)
defer gzw.Close()
Copy link
Copy Markdown
Contributor

@codysoyland codysoyland Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should probably check the error returned by the gzip writer (gzq.Close() writes a footer)


w = gzw
}

return cpio.FromLayer(layer, w)
}