Skip to content

ci: run the test suite on every push and PR - #423

Open
snehithareddy28 wants to merge 1 commit into
chaitanyagiri:mainfrom
snehithareddy28:ci/run-test-suite
Open

snehithareddy28 wants to merge 1 commit into
chaitanyagiri:mainfrom
snehithareddy28:ci/run-test-suite

Conversation

@snehithareddy28

@snehithareddy28 snehithareddy28 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

What & why

The repo ships 107 node:test files — 834 tests documenting real fixed bugs (hive routing, the circuit breaker, Windows cmd-shims, Arabic/RTL, the updater) — but CI never executes them. The effective merge gate today is tsc --noEmit plus the release-link check, so a change can silently re-break any tested behaviour and still merge.

This adds one npm run test:focused step to the existing Typecheck job, which already does the npm ci the tests need. On a fresh checkout of main the suite passes 834/834 in about ten seconds locally and about twenty-five on the runner — a real regression gate for well under a minute of CI, with no second npm ci, no new runner and no matrix change.

Rebased onto current main (6248293a); ci.yml has not moved since this was opened, so it still applies cleanly.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Docs
  • Build / CI

Evidence

Before

Today's CI on main (6248293a): the Typecheck job runs tsc and the release-link check and nothing else — the step list goes straight from "Typecheck (node + web)" to "Release links consistent", so not one of the 834 tests runs

After

This PR's own CI run: the new Test step passes on the runner in 27s and ends 1..834 / tests 834 / pass 834 / fail 0

The after image is this pull request's own Typecheck job, so the evidence is the change running against today's main rather than a reconstruction.


Notes for review:

@snehithareddy28
snehithareddy28 force-pushed the ci/run-test-suite branch 6 times, most recently from 8c0fbb8 to 306f4ae Compare September 2, 2026 13:00
@snehithareddy28

Copy link
Copy Markdown
Contributor Author

A current data point for this one, since main has moved a lot since it was opened.

Three PRs with tests have merged since (#424, #425, #426) and #495 is up with six more — none of them run in CI today, because the Typecheck job still has no test step. This branch is unchanged and still applies cleanly to current main (ci.yml has not moved).

The evidence runs for #495 execute exactly this step against today's main: 840/840 in ~30 s on macos-latest, and the same step catching a regression when the fix is left out.

Happy to rebase or squash anything if you'd like it in a different shape.

The repo ships 107 node:test files — 834 tests documenting real fixed bugs
in hive routing, the circuit breaker, Windows cmd-shims, Arabic/RTL and the
updater — but CI never executes them. The effective merge gate today is
`tsc --noEmit` plus the release-link check, so a change can silently
re-break any tested behaviour and still merge.

This adds one `npm run test:focused` step to the existing Typecheck job,
which already does the `npm ci` the tests need. On a fresh checkout of main
the suite passes 834/834 in about ten seconds locally and about twenty-five
on the runner — so this buys a real regression gate for well under a minute
of CI, with no second `npm ci`, no new runner and no matrix change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant