ci: run the test suite on every push and PR - #423
Open
snehithareddy28 wants to merge 1 commit into
Open
snehithareddy28 wants to merge 1 commit into
snehithareddy28 wants to merge 1 commit into
Conversation
snehithareddy28
force-pushed
the
ci/run-test-suite
branch
6 times, most recently
from
September 2, 2026 13:00
8c0fbb8 to
306f4ae
Compare
Contributor
Author
|
A current data point for this one, since main has moved a lot since it was opened. Three PRs with tests have merged since (#424, #425, #426) and #495 is up with six more — none of them run in CI today, because the Typecheck job still has no test step. This branch is unchanged and still applies cleanly to current The evidence runs for #495 execute exactly this step against today's Happy to rebase or squash anything if you'd like it in a different shape. |
snehithareddy28
force-pushed
the
ci/run-test-suite
branch
from
September 16, 2026 19:34
306f4ae to
d9042a6
Compare
snehithareddy28
force-pushed
the
ci/run-test-suite
branch
2 times, most recently
from
September 16, 2026 20:00
a1aee49 to
f6c522c
Compare
The repo ships 107 node:test files — 834 tests documenting real fixed bugs in hive routing, the circuit breaker, Windows cmd-shims, Arabic/RTL and the updater — but CI never executes them. The effective merge gate today is `tsc --noEmit` plus the release-link check, so a change can silently re-break any tested behaviour and still merge. This adds one `npm run test:focused` step to the existing Typecheck job, which already does the `npm ci` the tests need. On a fresh checkout of main the suite passes 834/834 in about ten seconds locally and about twenty-five on the runner — so this buys a real regression gate for well under a minute of CI, with no second `npm ci`, no new runner and no matrix change.
snehithareddy28
force-pushed
the
ci/run-test-suite
branch
from
September 17, 2026 05:30
f6c522c to
ac175cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The repo ships 107
node:testfiles — 834 tests documenting real fixed bugs (hive routing, the circuit breaker, Windows cmd-shims, Arabic/RTL, the updater) — but CI never executes them. The effective merge gate today istsc --noEmitplus the release-link check, so a change can silently re-break any tested behaviour and still merge.This adds one
npm run test:focusedstep to the existing Typecheck job, which already does thenpm cithe tests need. On a fresh checkout ofmainthe suite passes 834/834 in about ten seconds locally and about twenty-five on the runner — a real regression gate for well under a minute of CI, with no secondnpm ci, no new runner and no matrix change.Rebased onto current
main(6248293a);ci.ymlhas not moved since this was opened, so it still applies cleanly.Type of change
Evidence
Before
After
The after image is this pull request's own Typecheck job, so the evidence is the change running against today's
mainrather than a reconstruction.Notes for review:
npm ci, no new runner, no matrix change.6248293a: pristinemainpasses 834/834, andmainwith my three open fixes (fix(hooks): make an unbound hook socket loud, self-healing and visible #495, fix(worktree): never auto-discard a named agent's unintegrated work on PTY exit #496, feat(agents): reopen a closed agent instead of only deleting it #503) merged together passes 852/852 — so turning this on does not turnmainred, today or once those land.Discord: asr2805