-
Notifications
You must be signed in to change notification settings - Fork 27
feat(networks): add isolated Docker project networks #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fuchencong
wants to merge
2
commits into
main
Choose a base branch
from
feat/docker-named-networks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| package adapters | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| cerrdefs "github.com/containerd/errdefs" | ||
| containerapi "github.com/docker/docker/api/types/container" | ||
| "github.com/docker/docker/api/types/filters" | ||
| networkapi "github.com/docker/docker/api/types/network" | ||
| "github.com/docker/docker/client" | ||
|
|
||
| "agent-compose/pkg/networks" | ||
| ) | ||
|
|
||
| const ( | ||
| dockerSandboxProjectLabel = "agent-compose.project_id" | ||
| dockerSandboxDriverLabel = "agent-compose.driver" | ||
| ) | ||
|
|
||
| type dockerProjectNetworkClient interface { | ||
| NetworkList(context.Context, networkapi.ListOptions) ([]networkapi.Summary, error) | ||
| NetworkInspect(context.Context, string, networkapi.InspectOptions) (networkapi.Inspect, error) | ||
| ContainerInspect(context.Context, string) (containerapi.InspectResponse, error) | ||
| NetworkDisconnect(context.Context, string, string, bool) error | ||
| NetworkRemove(context.Context, string) error | ||
| Close() error | ||
| } | ||
|
|
||
| type DockerProjectNetworkCleaner struct { | ||
| newClient func() (dockerProjectNetworkClient, error) | ||
| } | ||
|
|
||
| func NewDockerProjectNetworkCleaner() *DockerProjectNetworkCleaner { | ||
| return &DockerProjectNetworkCleaner{newClient: func() (dockerProjectNetworkClient, error) { | ||
| return client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation()) | ||
| }} | ||
| } | ||
|
|
||
| func (c *DockerProjectNetworkCleaner) CleanupProjectNetworks(ctx context.Context, projectID string) error { | ||
| if c == nil || c.newClient == nil { | ||
| return fmt.Errorf("docker project network cleaner is not configured") | ||
| } | ||
| dockerClient, err := c.newClient() | ||
| if err != nil { | ||
| return fmt.Errorf("connect Docker Engine for project network cleanup: %w", err) | ||
| } | ||
| defer func() { _ = dockerClient.Close() }() | ||
| filter := filters.NewArgs( | ||
| filters.Arg("label", networks.ManagedLabel+"=true"), | ||
| filters.Arg("label", networks.ResourceLabel+"="+networks.ProjectNetworkResource), | ||
| filters.Arg("label", networks.ProjectIDLabel+"="+projectID), | ||
| ) | ||
| summaries, err := dockerClient.NetworkList(ctx, networkapi.ListOptions{Filters: filter}) | ||
| if err != nil { | ||
| return fmt.Errorf("list Docker networks for project %s: %w", projectID, err) | ||
| } | ||
| for _, summary := range summaries { | ||
| inspect, err := dockerClient.NetworkInspect(ctx, summary.ID, networkapi.InspectOptions{}) | ||
| if err != nil { | ||
| if cerrdefs.IsNotFound(err) { | ||
| continue | ||
| } | ||
| return fmt.Errorf("inspect Docker network %s: %w", summary.ID, err) | ||
| } | ||
| if inspect.Labels[networks.ManagedLabel] != "true" || inspect.Labels[networks.ResourceLabel] != networks.ProjectNetworkResource || inspect.Labels[networks.ProjectIDLabel] != projectID { | ||
| return fmt.Errorf("refuse to clean Docker network %s with mismatched ownership", inspect.Name) | ||
| } | ||
| for containerID := range inspect.Containers { | ||
| containerInfo, err := dockerClient.ContainerInspect(ctx, containerID) | ||
| if err != nil { | ||
| if cerrdefs.IsNotFound(err) { | ||
| continue | ||
| } | ||
| return fmt.Errorf("inspect endpoint container %s on network %s: %w", containerID, inspect.Name, err) | ||
| } | ||
| labels := map[string]string(nil) | ||
| if containerInfo.Config != nil { | ||
| labels = containerInfo.Config.Labels | ||
| } | ||
| if labels[dockerSandboxProjectLabel] != projectID || labels[dockerSandboxDriverLabel] != "docker" { | ||
| return fmt.Errorf("refuse to disconnect unknown endpoint container %s from project network %s", containerID, inspect.Name) | ||
| } | ||
| if err := dockerClient.NetworkDisconnect(ctx, inspect.ID, containerID, false); err != nil && !cerrdefs.IsNotFound(err) { | ||
| return fmt.Errorf("disconnect container %s from project network %s: %w", containerID, inspect.Name, err) | ||
| } | ||
| } | ||
| if err := dockerClient.NetworkRemove(ctx, inspect.ID); err != nil && !cerrdefs.IsNotFound(err) { | ||
| return fmt.Errorf("remove project network %s: %w", inspect.Name, err) | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.