Add deprecation warnings to functions that should be deprecated#291
Open
Add deprecation warnings to functions that should be deprecated#291
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3,7 +3,9 @@ | |||
| from collectoss.tasks.util.random_key_auth import RandomKeyAuth | |||
| from collectoss.tasks.github.util.github_api_key_handler import GithubApiKeyHandler | |||
| from sqlalchemy.orm import Session | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused Session imported from sqlalchemy.orm (unused-import)
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ported from augurlabs/augur#3788
This uses the typing_extensions library to add the @deprecated decorator for some of the older python versions we support and marks several functions as deprecated so peoples editors can highlight them and their uses can be phased out over time.
There were several functions in the repo with deprecations noted in comments, but none were properly marked as deprecated in a way that peoples editors would see.
Notes for Reviewers
Needs testing - drafting until i can get to it
This should only affect developers, so as long as the imports dont cause problems on first startup, id consider this ready
Signed commits