Bypass collecting pull request data when PRs are disabled#306
Open
Bypass collecting pull request data when PRs are disabled#306
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
for better handling of future query param encoding needs and sharing responsibility for url creation (GhDA owns the domain/base url, the caller owns the path and query params they want to use) Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
… this in the future Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…g what it already does Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Contributor
Author
|
Credit to @iGufrankhan for the initial concept/implementation for this fix that ended up in the commits |
1 task
cdolfi
approved these changes
May 7, 2026
Contributor
cdolfi
left a comment
cdolfi
left a comment
There was a problem hiding this comment.
I havent tested but everything lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a function to
GithubDataAccessto enable the status of pull requests to be detected at the start of the PR collection job and short-curcuit if PRs are not enabled, thus avoiding a task failure.This may only be a PARTIAL FIX for the general case of "things are failing because prs are disabled". I need to disentangle the various issues that have been filed for this.
This PR fixes #229 in the narrow case of pull request collection.
Notes for Reviewers
Signed commits