This repository was archived by the owner on Jun 23, 2022. It is now read-only.
Add Symfony 5 and PHP 8 compatibility#11
Open
cedricziel wants to merge 9 commits intochaplean:masterfrom
Open
Conversation
added 9 commits
January 29, 2021 09:29
* bump minimal PHP version to 7.1 to allow PHPUnit void return types * add `:void` return type to test `setUp` methods to match super * add Symfony 5 to the dependency range * constrain mockery dependency to `^1.3.3` to make it installable on PHP 7.1, dev-master was too wide
…ManagerRegistry on Symfony 4.4+
The base event was ripped out and thus we need to either extend from the old or the new one.
Depending on availability of contracts event
The Symfony mailer can template on its own
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We want to use this bundle with PHP8 and Symfony 5
Things done
:voidreturn type to testsetUpmethods to match super^1.3.3to make it installable on PHP 7.1, dev-master was too wideThis change is