Fix code issues to make main compile again - #73
Open
SwishSwushPow wants to merge 1 commit into
Open
SwishSwushPow wants to merge 1 commit into
SwishSwushPow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📇 Description
Hi everyone 👋 I was looking at supercluster because the dependencies resolved a bit awkwardly in our own project, so I wanted to build it locally and see if I could tweak things. I noticed that checking out the
mainbranch left me with a state I couldn't compile, so I started to fix these issues.The bump for the Rust version to 1.88.0 is required to be able to build the
geojsondependency I think. Otherwise we get the following error:🚨 Checklist
🧪 Tests
There are still issues with tests I think, but I have not yet fixed them because I haven't had the time to figure out what is going on there or if I'm just running them incorrectly. 😅