feat(frontend): add regional English locales#1532
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Users cannot explicitly choose an English regional variant, so the generic
enlocale mixes regional wording and can hide formatting differences.What changed
en-GBthe canonical locale, adds sparseen-USwording overrides, and exposes both choices in Display settings.enpreferences toen-GB, preserves exact regional negotiation and document metadata, and keeps regional date/time conventions authoritative.Test plan
mise test-frontend— 246 files and 2,114 tests passed.mise x -- pnpm run check— Svelte check passed with 0 errors and 0 warnings.mise x -- pnpm run lintandmise license-checkpassed.mise x -- pnpm exec playwright test e2e/user-settings.test.ts --retries=0— all 8 browser tests passed.mise x -- pnpm run buildpassed; theen-USpayload is approximately 14 KB gzipped.Compatibility: existing
enpreferences migrate automatically; there are no protobuf, public API, security, or operational changes.