Require forcePowerW for Force Charge/Discharge work mode writes - #22
Closed
jkpe wants to merge 1 commit into
Closed
Conversation
Accept and validate forcePowerW on POST /v1/control/work-mode for modes 3 and 4, and pass it through to writeWorkMode instead of defaulting to 5 kW. Co-authored-by: Jack Pearce <jkpe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/control/work-modenow acceptsforcePowerWand requires it when setting Force Charge (mode 3) or Force Discharge (mode 4). The value is passed through towriteWorkModeinstead of silently defaulting to 5 kW.Changes
forcePowerWas an integer between 1 and 6000 watts for force modesforcePowerWthrough HTTP handler,FoxModbusClient.setWorkMode, andwriteWorkModeCompanion PR
Paired with the Check My Solar app changes that prompt users for charge/discharge power in the Work Mode modal.