refactor: Phase 1 PR1/7 — Extract UtilityFunctions IIFE module

[cheerc]

Phase 1 Canary PR: UtilityFunctions IIFE Extraction

Part of #129 Phase 1 (PR1/7)

What Changed

Extracts 7 pure utility functions from JavaScript.html's monolithic App object into a new UtilityFunctions.js.html IIFE-wrapped module, establishing the pattern for all subsequent Phase 1 PRs.

Files Changed (Scope Gate: 4 files)

File	Change
UtilityFunctions.js.html	NEW — IIFE module with 7 pure functions
JavaScript.html	Remove 7 methods (replaced with comments), remove App.init() call
Index.html	Add UtilityFunctions include + App.init() trigger at end
tests/unit/appWiringContracts.test.js	Add IIFE_EXTRACTED classification, update counts

Methods Extracted

All are pure functions with zero internal dependencies:

• getShortUserName(email)
• generateUniqueId()
• stringToHashCode(str)
• timeToMinutes(timeStr)
• formatTime(timeStr)
• formatTimestampForFilename(timestamp)
• hexToRgb(hex)

Key Design Decision: App.init() Trigger

App.init() moved from JavaScript.html IIFE to Index.html as <script>App.init();</script> — ensures all domain modules are loaded and methods attached to App before initialization runs.

Load order:

Config → Elements → Api → Modals → History → UI → Interaction
→ JavaScript.html (App object + state + window.App = App)
→ UtilityFunctions.js.html (attaches utility methods to App)
→ <script>App.init();</script> (trigger)

Verification

• ✅ npm test: 1147/1147 tests pass (36 files)
• ✅ Coverage unchanged: Stmts 70.5%, Branch 76.7%, Funcs 84.9%, Lines 69.8%
• ✅ Scope gate: exactly 4 files changed
• ✅ Follows spec from docs/plans/2026-06-24-phase1-iife-refactoring.md

[cheerc]

✅ VERIFIED — Phase 1 PR1 UtilityFunctions IIFE Extraction

Reviewed HEAD: 903c7ad
Reviewer: cb-team-reviewer (independent, non-Claude vantage)

Findings: 0 CRITICAL, 0 WARNING

All 7 methods faithfully extracted with identical logic. App exposure order correctly addressed (window.App created by JavaScript.html IIFE → UtilityFunctions.js.html attaches methods → Index.html triggers App.init()). Wiring test updates consistent (48→41 public methods, new IIFE_EXTRACTED category).

Stage 1 — Correctness ✅

• Method movement fidelity: 7/7 identical function bodies
• IIFE pattern: (function(App){...})(App) correct
• App.init() deferred to Index.html: correct
• wiring contract counts: 48-7=41 ✅
• No conflict markers

Stage 2 — Adversarial ✅

• Zero additional findings. Clean canary PR.

Evidence

• gh pr diff 145 — 4 files, +110/-64 lines
• rg conflict markers — 0 matches
• Manual body comparison: all 7 functions identical between original and extraction