refactor: Phase 1 PR2/7 — Extract LockManager IIFE module

[cheerc]

Phase 1 PR2: LockManager IIFE Extraction

Part of #129 Phase 1 (PR2/7) — Wave A: 2/3

What Changed

Extracts 6 lock management methods from JavaScript.html into a new LockManager.js.html IIFE module. Unlike PR1 (pure functions), these methods access App state (tabId, activeScheduleId, isReadOnly) so all this.xxx references are converted to App.xxx.

Files Changed (Scope Gate: 5 files)

File	Change
LockManager.js.html	NEW — IIFE module with 6 lock methods
JavaScript.html	Remove 6 methods (replaced with breadcrumb comments)
Index.html	Add LockManager.js include after UtilityFunctions.js
tests/unit/appWiringContracts.test.js	Move methods to IIFE_EXTRACTED, count 41→37
tests/unit/syncMethodsWiring.test.js	Load LockManager source, update this→App patterns

Methods Extracted

Method	Type	this→App conversions
_getLocks	private	0 (uses localStorage only)
_saveLocks	private	0 (uses localStorage only)
acquireLock	public	3 (_getLocks, _saveLocks, tabId)
releaseLock	public	3 (_getLocks, _saveLocks, tabId)
releaseCurrentLock	public	2 (releaseLock, activeScheduleId)
refreshLockHeartbeat	public	5 (isReadOnly, activeScheduleId, _getLocks, _saveLocks, tabId)

Load Order

Config → Elements → Api → Modals → History → UI → Interaction
→ JavaScript.html (App object + state)
→ UtilityFunctions.js.html (PR1)
→ LockManager.js.html (PR2)  ← NEW
→ <script>App.init();</script>

Verification

• ✅ npm test: 1147/1147 tests pass (36 files)
• ✅ npx eslint --ext .html .: 0 errors, 8 warnings (pre-existing)
• ✅ Scope gate: 5 files changed
• ✅ this→App conversion verified in all 6 methods

[cheerc]

✅ VERIFIED

Reviewer: cb-team-reviewer
Reviewed HEAD: cf6e8429ba64dc75c6a6f7ff7c0af9bdea194306
Audit mode: D2 (1-hop import chain, correctness)
Skills: review-task-loop, ecc-code-reviewer

Files Reviewed

• LockManager.js.html (70 lines, NEW) — IIFE module with 6 lock methods
• JavaScript.html (-54/+6 lines) — 6 methods removed, breadcrumb comments left
• Index.html (+1 line) — LockManager include in load order
• tests/unit/appWiringContracts.test.js (±18 lines) — method classification updates
• tests/unit/syncMethodsWiring.test.js (±75 lines) — IIFE pattern support + this→App pattern updates

Summary

Phase 1 PR2/7: Extracts 6 lock management methods from JavaScript.html into a new LockManager.js.html IIFE module. All this.xxx references correctly converted to App.xxx.

this→App Conversion Verification (Critical Check)

Zero this. references remain in LockManager.js.html — verified via grep -n 'this\.'.

Original 6 methods had 13 distinct this. conversion sites (some repeated across methods):

Method	Original this.	Converted App.	✅
_getLocks	0 (uses localStorage)	0	✅
_saveLocks	0 (uses localStorage)	0	✅
acquireLock	_getLocks, tabId ×2, _saveLocks	All → App.	✅
releaseLock	_getLocks, tabId, _saveLocks	All → App.	✅
releaseCurrentLock	releaseLock, activeScheduleId	All → App.	✅
refreshLockHeartbeat	isReadOnly, activeScheduleId ×3, _getLocks, _saveLocks, tabId	All → App.	✅

Load Order Verification (D2 1-hop)

Config.js.html (L468) → defines AppConfig ← used by refreshLockHeartbeat
...
JavaScript.html (L475) → defines App object
UtilityFunctions.js.html (L476) → PR1
LockManager.js.html (L477) → PR2, receives `App` via IIFE param
<script>App.init()</script> (L478)

AppConfig.ALL_SCHEDULES_ID available (Config loads at L468) ✅. App defined before LockManager loads ✅.

Stage 1 — Correctness

Zero findings:

• No conflict markers
• All 6 methods faithfully extracted (line-by-line verified against main:L742-795)
• Breadcrumb comments left in JavaScript.html for traceability
• IIFE pattern: (function(App) { ... })(App) — correct closure
• appWiringContracts: methods correctly reclassified (PRIVATE_HELPERS/NOT_EXTRACTABLE/EXTRACTED_TO_LIB → IIFE_EXTRACTED)
• Public method count 41→37 (4 public lock methods removed from JavaScript.html)
• Private helpers filter updated to check IIFE_EXTRACTED
• syncMethodsWiring: extractMethodBody enhanced with IIFE pattern fallback
• All lock method wiring assertions updated this\. → App\.
• Lock methods now tested against lockManagerSource (not jsHtmlSource)

Stage 2 — Adversarial

Zero findings:

• refreshLockHeartbeat references AppConfig.ALL_SCHEDULES_ID — verified AppConfig loaded at L468 before LockManager at L477
• IIFE receives App as parameter but also uses AppConfig directly from global scope — this is consistent with existing GAS pattern (AppConfig is always global, never passed as IIFE param)
• Method bodies are exact copies except this. → App. — no logic changes, no subtle rewrites
• extractMethodBody regex enhancement handles both methodName: function() (JS.html) and App.methodName = function() (IIFE) patterns correctly

Evidence

• ran: gh pr view 146 --json headRefOid → cf6e8429ba64dc75c6a6f7ff7c0af9bdea194306 (SHA aligned)
• ran: grep -n 'this\.' LockManager.js.html → NO this. references found (all 13 converted)
• ran: grep -nc 'App\.' LockManager.js.html → 22 App. references (13 conversions + 9 method assignments)
• ran: gh api .../JavaScript.html?ref=main | sed -n 742,795p → original source verified
• ran: gh api .../Index.html | grep -n AppConfig\|LockManager\|JavaScript\|init → load order verified (Config L468 → JavaScript L475 → LockManager L477 → init L478)
• cited: LockManager.js.html:L31 — existingLock.tabId !== App.tabId (was this.tabId)
• cited: LockManager.js.html:L58-62 — refreshLockHeartbeat with App.isReadOnly, App.activeScheduleId, AppConfig.ALL_SCHEDULES_ID — all converted
• cited: JavaScript.html:L742-744 — breadcrumb: // _getLocks — moved to LockManager.js.html (Phase 1 PR2)