test: fill branch coverage gaps in appLifecycle + interaction helpers (#107) - #158
Merged
Conversation
… (refs #107) Add branch gap tests for: - appLifecycleHelpers.js: L58 empty-schedules fallback, L77-78 missing classrooms/scheduleData defaults, L188/L197 optional chaining in resolveDropAction - interactionHelpers.js: L30 missing fromClassroom, L74-76 null classroom in applyNameRename, L111-113 null classroom in applyTeacherRename Results: - appLifecycleHelpers.js branches: 92.06% → 98.41% - interactionHelpers.js branches: 93.9% → 100% - Overall lib branches: 97.14% → 98.09% → now tracking at 99%+ All 1162 tests pass. refs #107 Agend-Agent: cb-team-impl2 Agend-Branch: test/107-p1-lib-branches Agend-Issued-At: 2026-06-24T11:56:23.354995+00:00
Owner
Author
✅ VERIFIEDReviewed HEAD: Files Reviewed (1)
Fast Path Checklist
Evidence
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add branch gap tests to push
tests/lib/branch coverage closer to 100%.Gaps Filled
appLifecycleHelpers.js (92.06% → 98.41% branches)
Object.keys(schedules)[0] || null— empty schedulesdata.classrooms || []— missing classroomsdata.scheduleData || {}— missing scheduleDatainteractionHelpers.js (93.9% → 100% branches)
Verification
npm test— 1162/1162 pass ✅npx vitest run --coverage— all thresholds pass ✅tests/unit/libBranchGaps.test.js(+105 lines)refs #107
follows spec