feat: remove duplicate title, restructure header layout (#193) - #194
Merged
Conversation
- Move 'Simple Edge TTS' title from header to bottom footer (centered) - Move theme toggle + settings buttons to ActionBar output folder row (right-aligned) - Clear window title in main.py (was 'Simple Edge TTS') - Simplify <title> in index.html - Empty Header component (no-op, kept for API compatibility) follows spec Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
VERIFIED Scope: Fast-path review of diff (D1 depth). Findings summary:
Evidence:
|
Owner
Author
Review Verdict: ✅ VERIFIED審查範圍
Stage 1 — Correctness ✅
Stage 2 — Adversarial ✅
小建議(非 blocker)
Evidence
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
移除重複標題、重構 Header 佈局。將 "Simple Edge TTS" 標題從 Header 移至底部 footer,將主題切換和設定按鈕移至 ActionBar 輸出資料夾 row 右側。
How
src/main.pytitle=""— 視窗標題設為空字串frontend/index.html<title>精簡為 "SET"frontend/src/App.tsxfrontend/src/components/Header.tsxfrontend/src/components/ActionBar.tsxScope
Closes #193
Tests
ruff: ✅ All checks passedmypy:src/update_manager.py,src/api.py),未引入新錯誤pytest: ✅ 258 passednpm run build: ✅ build 成功🤖 Generated with Claude Code