habitat: add core/zlib dependency to Windows plan #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add core/zlib to habitat/plan.ps1 package dependencies. This fixes a runtime warning when running chef-cli generate cookbook inside the Habitat package where ffi-libarchive cannot load libarchive. Signed-off-by: Sachin Jain <Sachin.jain@chef.io>
Simplecov Report
|
sanjain-progress
force-pushed
the
fix/lib_archive_warning
branch
from
296fbc3 to
64325cb
Compare
|
sanghinitin
approved these changes
Jan 20, 2026
ashiqueps
approved these changes
Jan 20, 2026
nikhil2611
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
core/zlibto the Windows Habitat plan dependencies (habitat/plan.ps1).Issues Resolved
Resolves a warning observed when running
chef-cli generate cookbookcommands within the Windows Habitat package:The `ffi-libarchive` gem requires the underlying library to be available, and explicitly adding
core/zlibalongsidecore/libarchiveensures the necessary shared objects are loaded correctly on Windows.Checklist
hab pkg exec chef/chef-cli -- chef-cli generate cookbook test-cookbookDescription
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.