Backport #1964: Fix Encoding::CompatibilityError in hostnamectl plugin - #1966
Merged
Conversation
Mixlib::ShellOut returns stdout as ASCII-8BIT, so matching the UTF-8 icon-stripping regexp against it raises as soon as hostnamectl emits a multibyte character, truncating the attribute mash. Coerce the encoding before the gsub, and make the existing emoji spec fixtures binary so they exercise the path they were written to cover. Signed-off-by: Karl Amrhein <karlamrhein@gmail.com> Co-authored-by: Karl Amrhein <karlamrhein@gmail.com> (cherry picked from commit 54b17dd) Signed-off-by: Thomas Powell <104777878+tpowell-progress@users.noreply.github.com>
tpowell-progress
added
the
ai-assisted
tpowell-progress
enabled auto-merge (squash)
August 11, 2026 22:50
johnmccrae
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #1964 to
18-stable. Clean cherry-pick, no conflicts.Changes Made
Testing
This work was completed with AI assistance following Progress AI policies