Negotiating ECE#54
Closed
chenBright wants to merge 1 commit into
Closed
Conversation
b975147 to
b060e3b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end Enhanced Connection Establishment (ECE) negotiation support to the RDMA v3 (“RDM3”) handshake by extending the protobuf hello message, soft-loading the necessary libibverbs APIs, and adding unit tests that validate the degrade-safe wire behavior under UT/no-hardware mode.
Changes:
- Extend the v3 handshake protobuf (
RdmaHello) to optionally carry an ECE capability block. - Soft-load
ibv_query_ece/ibv_set_eceso RDMA init can succeed on older libibverbs (ECE disabled when unavailable). - Add UTs that ensure v3 hello round-trips with/without ECE and that server replies omit ECE in degrade cases.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test/brpc_rdma_unittest.cpp |
Adds UT coverage for v3 hello ECE field presence/absence and degrade-safe server replies. |
src/brpc/rdma/rdma_helper.cpp |
Makes ECE-related ibverbs symbols optional at runtime via soft-loading. |
src/brpc/rdma/rdma_handshake.proto |
Adds optional RdmaEce message to the v3 hello protobuf schema. |
src/brpc/rdma/rdma_handshake.h |
Extends parsed handshake state to carry optional ibv_ece for v3 peers. |
src/brpc/rdma/rdma_handshake.cpp |
Implements client-side ECE capability query + hello advertisement and v3 hello encode/decode for ECE. |
src/brpc/rdma/rdma_endpoint.h |
Adds per-endpoint storage for the next outgoing ECE payload to advertise. |
src/brpc/rdma/rdma_endpoint.cpp |
Updates QP bring-up signature and adds server-side negotiated ECE query for reply hello. |
.github/workflows/ci-linux.yml |
Runs the full Bazel test suite for the RDMA-configured job (removes prior filter). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previously BringUpQp only did a local ibv_query_ece + ibv_set_ece roundtrip and never exchanged ECE capabilities with the peer. This patch wires up the standard requestor/responder ECE negotiation flow on top of the existing v3 handshake without adding any extra round trip: 1. Client queries local ECE, advertises it in its v3 hello. 2. Server applies the client's ECE in INIT->RTR (set_ece), then after RTS queries the reduced/negotiated ECE and sends it back in the reply hello. 3. Client applies the server's reduced ECE in INIT->RTR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
The RDMA endpoint already declares the intent to do ECE (Enhanced Connection Establishment) negotiation (
BringUpQpis gated byFLAGS_rdma_ece), but the existing implementation never exchanges ECE capabilities between the two peers.What is changed and the side effects?
Changed:
This PR implements an end-to-end ECE negotiation in the v3 handshake.
RdmaHandshakeClientV3::SendLocalHello): query local ECE, store it in_outgoing_ece, advertise it in the v3 hello.BringUpQp): apply the client's ECE during INIT->RTR (ibv_set_ece). After QP reaches RTS,ibv_query_eceto obtain the reduced/negotiated ECE (the subset both peers support) and store it in_outgoing_ece.SendLocalHello→FillLocalRdmaHello): advertise the negotiated ECE in the reply hello.BringUpQp): apply the server's reduced ECE during INIT->RTR.Side effects:
Performance effects:
Breaking backward compatibility:
Check List: