Remove duplicate global key monitor#2
Open
sickn33 wants to merge 1 commit into
Open
Conversation
sickn33
force-pushed
the
fix-remove-duplicate-key-monitor
branch
from
63b344a to
c71ea8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MenuBarControllerKeyboardShortcutsWhy
AppDelegatealready registers global shortcuts viaKeyboardShortcuts.onKeyUpfor showing the shelf, clipboard history, and settings. The extraNSEvent.addGlobalMonitorForEvents(matching: .keyDown)path duplicates two of those shortcuts, cannot respect user customization, and can increase privacy/App Store review risk because it globally observes keyboard events.Verification
rg -n "addGlobalMonitorForEvents\\(matching: \\.keyDown|globalKeyMonitor|setupGlobalHotkeys|handleGlobalKeyEvent|Carbon|kVK_ANSI" DropKit/Sourcesreturns no matchesxcodebuild test -project DropKit/DropKit.xcodeproj -scheme DropKit -destination 'platform=macOS' -derivedDataPath /private/tmp/dropkit-hotkey-derived CODE_SIGNING_ALLOWED=NOpassed 11 tests, 0 failures