Add e_field attribute to Plasma object for electric field vector #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacklovell
approved these changes
Sep 11, 2024
Member
jacklovell
left a comment
jacklovell
left a comment
There was a problem hiding this comment.
Looks good to me. It would be nice to have a couple of simple unit tests to check setting and getting works (mainly useful for regression testing later on I expect).
Mateasek
approved these changes
Jan 8, 2025
Member
Mateasek
left a comment
Mateasek
left a comment
There was a problem hiding this comment.
Hi @vsnever
I think this one is good to go. As @jacklovell said, you could add tests, but looking at the code I don't see many options here. You could check that the property value is set to whatever autowrap_vectorfunction3d is supposed to return when given a valid input or None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #465 by introducing the
e_fieldattribute to thePlasmaobject for the electric field vector function. This electric field will be used in the newBeamEmissionMultipletmodel (#415) as an addition to the Lorentz field v⨉B.