Skip to content

Improve alert detail formatting in trip.py #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiabre merged 2 commits into from
Feb 17, 2026
Merged

Improve alert detail formatting in trip.py #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df8656b
Improve alert detail formatting in trip.py
chiabre Feb 17, 2026
9a7c90a
Bump version from 1.1.31 to 1.1.32
chiabre Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "MBTAclient"
version = "1.1.31"
version = "1.1.32"
description = "A Python client for interacting with the MBTA API"
readme = "README.md"
requires-python = ">=3.12"
Expand Down
12 changes: 9 additions & 3 deletions src/mbtaclient/trip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,15 @@ def alerts(self) -> Optional[set[str]]:
if self.mbta_alerts:
for mbta_alert in self.mbta_alerts:
effect = " ".join(mbta_alert.effect.split("_"))
short_header = mbta_alert.short_header
alerts_details.add(effect + ": " + short_header)
return alerts_details
short_header = mbta_alert.short_header.strip()
header = mbta_alert.header.strip() if hasattr(mbta_alert, "header") else ""

# Use short_header if available, otherwise fallback to full header
detail = short_header if short_header else header
if detail: # only add if detail is not empty
alerts_details.add(f"{effect}: {detail}")

return alerts_details if alerts_details else None
return None

def get_stop_by_type(self, stop_type: str) -> Optional[Stop]:
Expand Down
Loading